Call transactional methods via an injected dependency instead of directly via ‘this‘

A_bad_horse

于 2023-12-14 11:30:31 发布

阅读量3.4k

点赞数 8

分类专栏： Spring Boot 文章标签： java 前端数据库

本文链接：https://blog.youkuaiyun.com/A_bad_horse/article/details/134991431

版权

Spring Boot 专栏收录该内容

43 篇文章

订阅专栏

本文介绍了在使用SonarLint扫描SpringBoot应用代码时遇到的问题，涉及@Transactional注解引发的错误。通过引入spring-boot-starter-aop依赖，启用AOP代理并修改UserInfoService中的代码，成功解决了问题。

摘要生成于 C知道，由 DeepSeek-R1 满血版支持，前往体验 >

问题描述

使用SonarLint扫描代码时，报错如下

@Slf4j
@Service
@RequiredArgsConstructor
public class UserInfoService {
    private final UserMapper userMapper;

    @Transactional(readOnly = true)
    public ResponseResult getUserInfo(String username) {
        UserInfo userInfo = this.getUserInfoByUsername(username); // issue occur

        if (userInfo == null) {
            return ResponseResult.failure(StatusCode.MESSAGE, username + " does not exist, please input username again!");
        } else {
            return ResponseResult.success(userInfo);
        }
    }

    @Transactional(readOnly = true)
    public UserInfo getUserInfoByUsername(String username) {
        return userMapper.getUserByUsername(username);
    }
}

解决方案

第一步：引入依赖

<dependency>
    <groupId>org.springframework.boot</groupId>
    <artifactId>spring-boot-starter-aop</artifactId>
    <version>3.2.0</version>
</dependency>

第二步：enable 代理

@SpringBootApplication
@EnableAspectJAutoProxy(exposeProxy = true) // add config
public class WebSystemApplication {
    public static void main(String[] args) {
        SpringApplication.run(WebSystemApplication.class, args);
    }
}

第三步：修复问题

@Slf4j
@Service
@RequiredArgsConstructor
public class UserInfoService {
    private final UserMapper userMapper;

    @Transactional(readOnly = true)
    public ResponseResult getUserInfo(String username) {
        UserInfoService u = (UserInfoService) AopContext.currentProxy(); // use proxy
        UserInfo userInfo = u.getUserInfoByUsername(username);

        if (userInfo == null) {
            return ResponseResult.failure(StatusCode.MESSAGE, username + " does not exist, please input username again!");
        } else {
            return ResponseResult.success(userInfo);
        }
    }

    @Transactional(readOnly = true)
    public UserInfo getUserInfoByUsername(String username) {
        return userMapper.getUserByUsername(username);
    }
}