iptables too long bug fixd（n^2 -> nlogn）

Change-Id: Ia5e26a5bd76a24cbd4b9b90351ba567ea13c4062 Owner enikanorov Project openstack/neutron Branch master Topic bug/1352826 Uploaded Dec 4, 2014 1:18 AM Updated Dec 4, 2014 4:53 AM Status Abandoned

Commit Message Permalink (WIP)Improve the performance of _modify_rules() in IptablesManager Implement a new algorithm for _modify_rules(), which reduces the complexity from O(n^2) to O(nlogn). The new code does not change any behavior of _modify_rules(). A new unit test is also added for _modify_rules(). Change-Id: Ia5e26a5bd76a24cbd4b9b90351ba567ea13c4062 Closes-Bug: 1352826

Reviewer   Verified Workflow enikanorov     A10 Networks CI       Ryu CI       Midokura CI       OpenContrail CI       Qin Zhao       Brocade Vyatta CI       Mellanox CI       Carl Baldwin       Brocade LBaaS CI       Metaplugin CI       Arista CI       Jenkins   +1   PLUMgrid CI   +1   NEC CI   +1   vArmour CI   +1   Microsoft Hyper-V CI   +1   Nuage CI   +1   IBM SDN-VE CI   +1   Need Verified

Jenkins check Dec 4, 2014 2:15 AM gate-neutron-pep8 SUCCESS in 2m 08s gate-neutron-docs SUCCESS in 1m 15s gate-neutron-python27 SUCCESS in 17m 42s check-tempest-dsvm-neutron-pg SUCCESS in 43m 08s check-tempest-dsvm-neutron-full SUCCESS in 44m 50s check-tempest-dsvm-neutron-pg-full SUCCESS in 39m 02s (non-voting) gate-tempest-dsvm-neutron-large-ops SUCCESS in 19m 16s check-grenade-dsvm-neutron SUCCESS in 48m 02s check-neutron-dsvm-functional SUCCESS in 13m 21s gate-rally-dsvm-neutron-neutron SUCCESS in 18m 21s (non-voting) check-tempest-dsvm-neutron-pg-2 SUCCESS in 43m 12s check-tempest-dsvm-neutron-full-2 SUCCESS in 43m 02s check-tempest-dsvm-neutron-pg-full-2 SUCCESS in 36m 33s (non-voting) check-tempest-dsvm-neutron-dvr SUCCESS in 26m 10s (non-voting) gate-neutron-pylint SUCCESS in 6m 16s Brocade Vyatta CI check Dec 4, 2014 1:24 AM brocade-ci-oss FAILURE Ryu CI check Dec 4, 2014 1:25 AM check-tempest-dsvm-ofagent FAILURE in 6m 41s Metaplugin CI check Dec 4, 2014 1:28 AM check-tempest-dsvm-metaplugin FAILURE in 9m 07s NEC CI check Dec 4, 2014 1:29 AM Neutron_Gate SUCCESS in 10m 00s IBM SDN-VE CI check Dec 4, 2014 1:52 AM ibm-dsvm-tempest-full SUCCESS in 18m 08s Brocade LBaaS CI check Dec 4, 2014 2:07 AM brocade-adx-ci-job FAILURE (skipped) A10 Networks CI check Dec 4, 2014 3:32 AM a10-neutron-tempest SUCCESS in 16m 37s Midokura CI check Dec 4, 2014 4:53 AM check-tempest-neutron-midonet-plugin SUCCESS in 2h 46m 06s

Dependencies

Reference Version:

BasePatch Set 1

Patch Set 1

b4e9c4368220ff4d72f62ad6208a2148372091bf (gitweb)

Author Qin Zhao <chaochin@gmail.com> Aug 21, 2014 1:24 AM Committer Eugene Nikanorov <enikanorov@mirantis.com> Dec 4, 2014 1:17 AM Parent(s) 860c3819ca9d0691dcd9159210b7f7904f4d993b Merge "Adds macvtap support" Download checkout pull cherry-pick patch Anonymous HTTP git fetch https://review.openstack.org/openstack/neutron refs/changes/93/138793/1 && git checkout FETCH_HEAD     File Path Comments Size Diff   Commit Message     Side-by-Side Unified   M neutron/agent/linux/iptables_manager.py   +145, -103 Side-by-Side Unified   M neutron/tests/unit/test_iptables_manager.py   +78, -0 Side-by-Side Unified     +223, -103 All Side-by-Side All Unified

Comments

Expand Recent Expand All Collapse All

enikanorov

Uploaded patch set 1.

Dec 4 1:18 AM

enikanorov

Patch Set 1: Workflow-1 WIP based on patch of other author

Dec 4 1:19 AM

enikanorov

Abandoned

Dec 4 4:42 AM

Add Comment

Press '?' to view keyboard shortcuts  |  Powered by Gerrit Code Review (2.8.4-15-g6dc8444)  |  Report Bug