[JavaScript--代码98]：JS代码重构

最新推荐文章于 2022-01-21 23:24:27 发布

木瓜~

最新推荐文章于 2022-01-21 23:24:27 发布

阅读量317

点赞数

CC 4.0 BY-SA版权

分类专栏： JavaScript 文章标签：重构

本文链接：https://blog.youkuaiyun.com/corner2030/article/details/78560286

JavaScript 专栏收录该内容

23 篇文章

订阅专栏

本文通过具体示例展示了如何将复杂的 if-else 代码块重构为更简洁的形式，并介绍了一个初始化流程的改进方法，使得代码更加清晰易读。

摘要生成于 C知道，由 DeepSeek-R1 满血版支持，前往体验 >

1: if-else refactor

var instance;

function getFmService() {
    if (instance !== undefined) {
        return instance;
    } else {
        instance = createFmService();
        return instance;
    }
}

// => refactor
function getFmService(instance) {
    return instance !== undefined ? instance : createFmService();
}

var faults;
var EFaultIds = {};
function init() {
    if (_.isEmpty(faults)) {
        var product = determineProduct();
        if (product === "unknown") {
            // init later!
            logger.info("could not determine product for faults yet..");

            if (secondInitTriggerDefault !== true) {
                secondInitTriggerDefault = true;
                return Promise.resolve();
            } else {
                logger.info("still couldn't determine, defaulting to 5G");
                product = "5G";
            }
        }

        logger.info("initialized faults from %s", product + "_faults.json");
        faults = require("./" + product + "_faults.json");
    }

    if (!_.isEmpty(EFaultIds)) {
        return Promise.resolve();
    } else {
        return Promise.try(function() {
            _.each(faults, function(fault, id) {
                EFaultIds[fault.shortName] = id;
            });
        });
    }
}


// => refactor
function init() {
    var faults = {};
    var EFaultIds = {};
    var product = determineProduct();
    if (product === "unknown") {
         // init later!
          logger.info("could not determine product for faults yet..");

          if (secondInitTriggerDefault !== true) {
              secondInitTriggerDefault = true;
              return Promise.resolve({faults, EFaultIds});
          } else {
              logger.info("still couldn't determine, defaulting to 5G");
              product = "5G";
          }
      }

    logger.info("initialized faults from %s", product + "_faults.json");
    faults = require("./" + product + "_faults.json");

    if (_.isEmpty(EFaultIds)) {
        return Promise.try(function() {
            _.each(faults, function(fault, id) {
                EFaultIds[fault.shortName] = id;
            });
        });
    }
    return Promise.resolve({faults, EFaultIds});
}

//然后就可以这样使用了
function getEFaultIds() {
    return init()
        .then(function({fault, EFaultIds}) {
            return Promise.resolve(EFaultIds);
        });
}